select users with capability not only enrolled #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for this improvement and also thanks for fixing the form type warnings. I will do some testing and integrate it asap! |
|
Hi I have discussed this change and most peers find it strange that within a course for example a teacher of course X could decide that all global managers should receive notifications about enrollment for this specific course. I think such thing should only be possible in the global settings of the plugin, ie that there the admin can decide that all global managers receive enrollment notifications of all courses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this change make possible for non-enrolled users to be selected to be notified even if they are not enrolled on the course.
Many times managers are assigned global roles (or category roles) and are not enrolled on courses. With this change, they'll appear on the list to be notified.