Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stable #2204

Merged
merged 9 commits into from
Dec 10, 2024
Merged

Fix stable #2204

merged 9 commits into from
Dec 10, 2024

Conversation

simonihmig
Copy link
Collaborator

@simonihmig simonihmig commented Dec 10, 2024

Get stable branch green again. Mostly backporting changes from #2176.

@simonihmig simonihmig force-pushed the fix-stable-more branch 3 times, most recently from 58d9767 to 673cffb Compare December 10, 2024 10:51
@simonihmig simonihmig force-pushed the fix-stable-more branch 2 times, most recently from 60bd161 to 53d1906 Compare December 10, 2024 13:07
@simonihmig simonihmig marked this pull request as ready for review December 10, 2024 14:10
@simonihmig simonihmig requested a review from a team December 10, 2024 14:10
@@ -6,7 +6,7 @@ import { join } from 'path';
const { module: Qmodule, test } = QUnit;

appScenarios
.only('release')
.only('lts_5_12')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing with release, not sure why? cc @void-mAlex

release,
})
// exceeding GitHub actions limit of 256
.skip('lts_4_4')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping these to get around Strategy expansion exceeded 256 results for job 'test', see https://github.com/embroider-build/embroider/actions/runs/12254560402

@ef4 ef4 merged commit 88bedbb into stable Dec 10, 2024
227 checks passed
@ef4 ef4 deleted the fix-stable-more branch December 10, 2024 16:42
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants