read your browser targets from config/targets.js automatically #2195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed this during the weekly meeting as an alternative to embroider-build/app-blueprint#122
This implementation works, but we do have a problem. The set of supported targets has now changed. I tested out
ie 11
(just for laughs 😭) and I saw a lot of the following errors in the output:I'm not exactly sure this is a blocker but it's probably something that we should mention in the RFC 🤔 thoughts? One way to work around it I think would be to setup preset-env yourself in babel which makes me think this isn't a dealbreaker