Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read your browser targets from config/targets.js automatically #2195

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

mansona
Copy link
Member

@mansona mansona commented Dec 5, 2024

We discussed this during the weekly meeting as an alternative to embroider-build/app-blueprint#122

This implementation works, but we do have a problem. The set of supported targets has now changed. I tested out ie 11 (just for laughs 😭) and I saw a lot of the following errors in the output:

Transforming class syntax to the configured target environment ("chrome131", "firefox132", "ie11", "safari18.1" + 2 overrides) is not supported yet

I'm not exactly sure this is a blocker but it's probably something that we should mention in the RFC 🤔 thoughts? One way to work around it I think would be to setup preset-env yourself in babel which makes me think this isn't a dealbreaker

@ef4
Copy link
Contributor

ef4 commented Dec 5, 2024

I think it would be preferable to put this in the legacy vite plugin instead of the default ember one.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mansona mansona requested a review from ef4 December 5, 2024 22:26
@mansona mansona added the enhancement New feature or request label Dec 5, 2024
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mansona mansona merged commit b89b741 into main Dec 6, 2024
213 checks passed
@mansona mansona deleted the targets branch December 6, 2024 22:41
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants