Run compatPrebuild in a separate output directory #2192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue where
ember build
being invoked as part of the compatPrebuild plugin and vite itself would both run on the samedist
folder in conflicting ways. I believeember build
is cleaning up its output directory (dist
by default) before running the build. Which already is causing some conflicts, as I think Vite should own that directory, and it may or may not do that cleanup itself depending on itsemptyOutDir
config.I my case, the conflict was even larger as we were building to different targets inside of
dist
, likedist/test
anddist/production
(customoutDir
vite config). These outputs were meant to persist, but when running the build in test mode first and then it production, the production build would make ember-cli cleardist/**
, so after the build onlydist/production
is left.