Support v2 ember-source #2164
Merged
Support v2 ember-source #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These minor compatibility tweaks are needed to support an upcoming ember-source release that declares itself as a v2 addon.
ef4
commented
Nov 5, 2024
| @@ -1036,7 +1036,7 @@ export class CompatAppBuilder { | |||
|
|
|||
| let resolver = new Resolver(resolverConfig); | |||
| let resolution = resolver.nodeResolve( | |||
| 'ember-source/vendor/ember/ember-template-compiler', | |||
There was a problem hiding this comment.
This is only present on disk in the rewritten form of ember-source. Once it's v2 it doesn't get rewritten.
Merged
|
Upgrading from The error is Since this PR is the only one that shipped for embroider/[email protected], I guess it is related, but I don't really understand what could cause this… Any idea @ef4 ? Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These minor compatibility tweaks are needed to support an upcoming ember-source release that declares itself as a v2 addon.