Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unneeded util files #2138

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Delete unneeded util files #2138

merged 3 commits into from
Oct 2, 2024

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Oct 2, 2024 •
edited
Loading

Would slightly reduce the diff (and changelog) for: #2131

NullVoxPopuli
NullVoxPopuli commented Oct 2, 2024
View reviewed changes
packages/util/tests/dummy/app/index.html
{{content-for "body-footer"}}
</body>
</html>
<!-- not used, but required by ember-cli -->
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is another app/styles/app.css 🙈

mansona
mansona approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NullVoxPopuli NullVoxPopuli merged commit aa52b09 into main Oct 2, 2024
152 checks passed
@NullVoxPopuli NullVoxPopuli deleted the delete-unneeded-util-files branch October 2, 2024 22:02
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullVoxPopuli @mansona