Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual entrypoint export modules #2006

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

BlueCutOfficial
Copy link
Collaborator

@BlueCutOfficial BlueCutOfficial commented Jun 25, 2024

This PR follows #1957 and fixes #1960. It implements the second part of the issue:

We don't want Embroider to rely on define. Using this method should rather be an implementation detail that belongs to the Ember app. Instead of defining modules directly in the entrypoint.js, we would prefer this file to export modules, then the Ember app imports these modules and owns the define implementation.

  • It moves the module definition from Embroider internals to the Ember app.js
  • All modules to define now constitute the virtual entrypoint.js default export.

@BlueCutOfficial BlueCutOfficial changed the base branch from main to new-app-boot June 25, 2024 08:59
@BlueCutOfficial BlueCutOfficial force-pushed the virtual-entrypoint-export-modules branch from a49d44c to 1951960 Compare June 25, 2024 09:24
@BlueCutOfficial BlueCutOfficial changed the base branch from new-app-boot to main June 25, 2024 12:02
@BlueCutOfficial BlueCutOfficial force-pushed the virtual-entrypoint-export-modules branch from 0789167 to 52dc15d Compare June 26, 2024 09:11
… which are then define in app.js, d is no longer needed in the virtual entry template
@BlueCutOfficial BlueCutOfficial force-pushed the virtual-entrypoint-export-modules branch from 52dc15d to 1c787ef Compare June 26, 2024 09:13
@BlueCutOfficial BlueCutOfficial force-pushed the virtual-entrypoint-export-modules branch from 1552c7a to ced381a Compare June 26, 2024 13:28
@BlueCutOfficial BlueCutOfficial marked this pull request as ready for review June 26, 2024 14:22
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this merged 🎉 💪

packages/core/src/virtual-entrypoint.ts Outdated Show resolved Hide resolved
packages/core/src/virtual-entrypoint.ts Outdated Show resolved Hide resolved
@mansona
Copy link
Member

mansona commented Jun 26, 2024

my 2 comments are super minor and I don't think we should block the PR on them (unless you would prefer to address them?)

@mansona mansona added the enhancement New feature or request label Jun 26, 2024
@mansona mansona merged commit f73dd26 into main Jun 27, 2024
178 checks passed
@mansona mansona deleted the virtual-entrypoint-export-modules branch June 27, 2024 08:31
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work on the new app boot implementation
3 participants