-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual entrypoint export modules #2006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCutOfficial
force-pushed
the
virtual-entrypoint-export-modules
branch
from
June 25, 2024 09:24
a49d44c
to
1951960
Compare
…e then define in app.js
…ch are then define in app.js
BlueCutOfficial
force-pushed
the
virtual-entrypoint-export-modules
branch
from
June 26, 2024 09:11
0789167
to
52dc15d
Compare
… which are then define in app.js, d is no longer needed in the virtual entry template
BlueCutOfficial
force-pushed
the
virtual-entrypoint-export-modules
branch
from
June 26, 2024 09:13
52dc15d
to
1c787ef
Compare
BlueCutOfficial
commented
Jun 26, 2024
BlueCutOfficial
force-pushed
the
virtual-entrypoint-export-modules
branch
from
June 26, 2024 13:28
1552c7a
to
ced381a
Compare
mansona
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets get this merged 🎉 💪
my 2 comments are super minor and I don't think we should block the PR on them (unless you would prefer to address them?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #1957 and fixes #1960. It implements the second part of the issue:
app.js
entrypoint.js
default export.