Skip to content

Commit

Permalink
Merge pull request #2039 from embroider-build/fix-static-app-issues
Browse files Browse the repository at this point in the history
Fix/ static-app-test shouldn't trigger a build error `@babel/helper-modules-imports` not found
  • Loading branch information
mansona authored Jul 23, 2024
2 parents 324f52a + f1c7517 commit 024270b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
6 changes: 6 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion tests/scenarios/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"license": "MIT",
"devDependencies": {
"@babel/core": "^7.17.5",
"@babel/helper-module-imports": "7.24.7",
"@babel/plugin-proposal-decorators": "^7.17.2",
"@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.16.7",
Expand Down Expand Up @@ -105,4 +106,4 @@
"typescript": "^5.4.5",
"webpack": "^5.90.3"
}
}
}
1 change: 1 addition & 0 deletions tests/scenarios/static-app-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ wideAppScenarios
.map('static-app', project => {
project.linkDevDependency('bootstrap', { baseDir: __dirname });
project.addDevDependency(emberBootstrap());
project.linkDevDependency('@babel/helper-module-imports', { baseDir: __dirname });
project.linkDevDependency('@embroider/macros', { baseDir: __dirname });
project.linkDevDependency('ember-modifier', { baseDir: __dirname });

Expand Down

0 comments on commit 024270b

Please sign in to comment.