Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @typescript-eslint/* #307

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Upgrade @typescript-eslint/* #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ba8610
Upgrade @typescript-eslint/*
NullVoxPopuli Nov 9, 2024
9dfd62a
Upgrade eslint-plugin-ember
NullVoxPopuli Nov 10, 2024
3dafcd8
Remove hardcode for the ember-eslint-parser
NullVoxPopuli Nov 10, 2024
04f7861
New projects may not need this anyway -- instead of disabling lints, …
NullVoxPopuli Nov 10, 2024
2aa333f
New projects may not need this anyway -- instead of disabling lints, …
NullVoxPopuli Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions files/__addonLocation__/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,16 @@
"@types/ember__template": "^4.0.7",
"@types/ember__test": "^4.0.6",
"@types/ember__utils": "^4.0.7",
"@typescript-eslint/eslint-plugin": "^7.7.1",
"@typescript-eslint/parser": "^7.7.1",<% } %>
"@typescript-eslint/eslint-plugin": "^8.13.0",
"@typescript-eslint/parser": "^8.13.0",<% } %>
"@rollup/plugin-babel": "^6.0.4",
"babel-plugin-ember-template-compilation": "^2.2.5",
"concurrently": "^9.0.1",
"ember-source": "^5.4.0",
"ember-template-lint": "^6.0.0",<% if (packageManager === 'npm') { %>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diverging ember-eslint-parser versions causes eslint-plugin-ember to not be able to work with gjs/gts

"ember-eslint-parser": "^0.4.2",
<% } %>"eslint": "^8.56.0",
"ember-template-lint": "^6.0.0",
"eslint": "^8.56.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-ember": "^12.2.1",
"eslint-plugin-ember": "^12.3.1",
"eslint-plugin-import": "^2.30.0",
"eslint-plugin-n": "^17.10.3",
"eslint-plugin-prettier": "^5.2.1",
Expand Down
9 changes: 4 additions & 5 deletions files/__addonLocation__/src/template-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@

// import type MyComponent from './components/my-component';

// Remove this once entries have been added! 👇
// eslint-disable-next-line @typescript-eslint/no-empty-interface
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding new lint disables here, I've just commented out the whole thing

export default interface Registry {
// MyComponent: typeof MyComponent
}
// Uncomment this once entries have been added! 👇
// export default interface Registry {
// MyComponent: typeof MyComponent
// }
16 changes: 8 additions & 8 deletions files/__addonLocation__/unpublished-development-types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
import '@glint/environment-ember-loose';
import '@glint/environment-ember-template-imports';

declare module '@glint/environment-ember-loose/registry' {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding new lint disables here, I've just commented out the whole thing

// Remove this once entries have been added! 👇
// eslint-disable-next-line @typescript-eslint/no-empty-interface
export default interface Registry {
// Add any registry entries from other addons here that your addon itself uses (in non-strict mode templates)
// See https://typed-ember.gitbook.io/glint/using-glint/ember/using-addons
}
}
// Uncomment if you need to support consuming projects in loose mode
//
// declare module '@glint/environment-ember-loose/registry' {
// export default interface Registry {
// // Add any registry entries from other addons here that your addon itself uses (in non-strict mode templates)
// // See https://typed-ember.gitbook.io/glint/using-glint/ember/using-addons
// }
// }