chore: Keep certain packages in sync between addon and test-app #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSenter
force-pushed
the
senter-typerscript-parser
branch
from
7b6f926 to
09a1e5f
Compare
TSenter
force-pushed
the
senter-typerscript-parser
branch
from
09a1e5f to
393d8f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the checks in my fork, two fail consistently. I ran them again without upgrading to pnpm v9, and saw the same failures. I don't think they're related to these changes, however - specifically, the test failures are related to not finding the module
ember-source/dist/ember-template-compiler.js.