Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Because TS addons need to emit declarations, we need to set noEmit to false #271

Closed
wants to merge 0 commits into from

Conversation

NullVoxPopuli
Copy link
Collaborator

No description provided.

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Mar 11, 2024
@ef4
Copy link
Contributor

ef4 commented Mar 11, 2024

Perhaps emitDeclarationsOnly.

@NullVoxPopuli NullVoxPopuli marked this pull request as draft March 11, 2024 21:12
@NullVoxPopuli
Copy link
Collaborator Author

yeah -- more testing is def needed.

The main thing is that Glint silently fails if you have an invalid tsconfig.json 🙈
hopefully that can be resolved as well, but this PR mostly a reminder to me to actually test stuff locally (I made this PR from browser)

@simonihmig
Copy link
Collaborator

Can you share the context here? Why is this needed now, as it used to work just fine before?

@NullVoxPopuli
Copy link
Collaborator Author

if you add emitDeclarationOnly: true, you get silent fail, (exit 0), no declaration.

if you run tsc --decalaration to get debugging info on the config, you get this error:

❯ tsc --declaration
tsconfig.json:17:5 - error TS5053: Option 'emitDeclarationOnly' cannot be specified with option 'noEmit'.

17     "emitDeclarationOnly": true,
       ~~~~~~~~~~~~~~~~~~~~~


Found 1 error in tsconfig.json:17

@NullVoxPopuli
Copy link
Collaborator Author

Updated the config

@NullVoxPopuli
Copy link
Collaborator Author

Re-opened here: #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants