Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @glint/core to root package.json #265

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

miguelcobain
Copy link
Contributor

No description provided.

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Feb 26, 2024
@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Feb 26, 2024

Looks like ember-data is now requiring Node 20 😅 maybe that was a mistake? idk.

@SergeAstapov
Copy link
Contributor

Why this may be needed?

@miguelcobain
Copy link
Contributor Author

@SergeAstapov without this, you don't get autocomplete in gjs/gts files in vscode.

More info: typed-ember/glint#524

Discord: https://discord.com/channels/480462759797063690/491905849405472769/1211700527285534770

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Feb 26, 2024

the VSCode extension doesn't, by default, know how to find @glint/core.

If you have a monorepo, The Glint VSCode extension doesn't initially detect a @glint/core dependency and since folks, by default, don't seem to use VSCode's workspace feature to open individual workspaces (and instead opting to open the whole monorepo as a workspace), folks would previously need to configured "Library Path":

So adding @glint/core to the root package.json enables folks' VSCode to "work by default" without additional config

@SergeAstapov
Copy link
Contributor

Thank you for the explanation!

@NullVoxPopuli NullVoxPopuli merged commit fdbd1c8 into embroider-build:main Feb 27, 2024
17 of 21 checks passed
@github-actions github-actions bot mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants