Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify rootDir so that declarations can always be emitted with the correct paths. #233

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Specify rootDir so that declarations can always be emitted with the correct paths. #233

merged 2 commits into from
Dec 6, 2023

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli mentioned this pull request Dec 6, 2023
Closed
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review December 6, 2023 15:25
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Dec 6, 2023
mansona
mansona approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉 (I probably won't use it tho 😉 )

@NullVoxPopuli NullVoxPopuli merged commit d4b63ae into main Dec 6, 2023
19 checks passed
@NullVoxPopuli NullVoxPopuli deleted the NullVoxPopuli-patch-4 branch December 6, 2023 15:48
@github-actions github-actions bot mentioned this pull request Dec 6, 2023
Merged
This was referenced Dec 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

glint --declaration flattens and removes folders if there is no top-level module.
2 participants
@NullVoxPopuli @mansona