Replace C_NEW_STRING with MakeStringWithLen, as the former is mentioned

in the GAP headers as being deprecated. The latter is aliased to GAP_MakeStringWithLen in anticipation that this will hopefully be added to the libgap API; see gap-system/gap#4211 Refs #2
embray · Jan 12, 2021 · 3fc9bd3 · 3fc9bd3
1 parent f284a12
commit 3fc9bd3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/gappy/element.pyx b/gappy/element.pyx
@@ -343,12 +343,10 @@ cdef Obj make_gap_string(s) except NULL:
         >>> gap('string')  # indirect doctest
         "string"
     """
-    cdef Obj result
     try:
         GAP_Enter()
         b = str_to_bytes(s)
-        C_NEW_STRING(result, len(b), b)
-        return result
+        return GAP_MakeStringWithLen(b, len(b))
     finally:
         GAP_Leave()
 

diff --git a/gappy/gap_includes.pxd b/gappy/gap_includes.pxd
@@ -177,4 +177,4 @@ cdef extern from "gap/records.h" nogil:
 
 
 cdef extern from "gap/stringobj.h" nogil:
-    void C_NEW_STRING(Obj new_gap_string, int length, char* c_string)
+    Obj GAP_MakeStringWithLen "MakeStringWithLen" (char *, size_t)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -177,4 +177,4 @@ cdef extern from "gap/records.h" nogil:


		cdef extern from "gap/stringobj.h" nogil:
		void C_NEW_STRING(Obj new_gap_string, int length, char* c_string)
		Obj GAP_MakeStringWithLen "MakeStringWithLen" (char *, size_t)