Update to Ember 5.12 #2598
Update to Ember 5.12 #2598
Conversation
|
@patricklx could you please let me know if you notice anything wrong with this PR? I know it's huge and I don't expect you to review it line by line, but if you could please let me know what you think, that would be great, thank you! |
| name: 'ember-lts-3.16', | ||
| npm: { | ||
| devDependencies: { | ||
| '@ember/test-helpers': '^2.4.0', |
There was a problem hiding this comment.
also need to add ember-resolver v11.0.1 until ember-source < 4.12
There was a problem hiding this comment.
@patricklx Yeah, is that safe to do? I honestly don't know if we will use consuming app's resolvers when they boot inspector? If so, that sounds like a good fix.
There was a problem hiding this comment.
@RobbieTheWagner it's safe. It's only used for the UI. We do not consume it from app code
There was a problem hiding this comment.
Thanks @patricklx, that fixed some of the tests, but looks like we still have some issues.
There was a problem hiding this comment.
some are failing because of ember-cli-app-version, I do not think we need it. can just be removed from deps
There was a problem hiding this comment.
Okay, fixed those. Now it looks like just beta and canary are failing. Any ideas?
There was a problem hiding this comment.
Probably need more cleanup. Ember 6 beta removes support for extend prototypes. Some tests are clearly failing because of that. The others not sure yet. I can also have a look later or tomorrow
There was a problem hiding this comment.
Ah okay, we do have some findBy, filterBy, mapBy etc that we probably need to remove. Should we merge this as is and then work on removing those?
|
Since the beta and canary failures are not related to the changes here, I am going to go ahead and merge and we should fix deprecations in a separate PR. |
No description provided.