Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GH_PAT token to hopefully fix releases #2585

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

patricklx
Copy link
Collaborator

this is needed so that the tag push triggers a workflow run, which will not happen if using gihub bot token

@RobbieTheWagner
Copy link
Member

@patricklx can you please explain how this fixes the issue? Does GITHUB_DEPLOY_TOKEN exist already?

@patricklx
Copy link
Collaborator Author

It doesn't exist. Its an example of what needs to change

@RobbieTheWagner
Copy link
Member

@patricklx can you explain? I don't understand how changing a token would change how things work.

@patricklx
Copy link
Collaborator Author

The default GitHub token here would be used to create a git tag and push it.
We have a workflow that would then run on git tag push. The problem is that with the default GitHub token no workflows will be triggered.

https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow

@RobbieTheWagner RobbieTheWagner changed the title use deploy token Checkout with GH_PAT token to hopefully fix releases Jul 26, 2024
@RobbieTheWagner RobbieTheWagner changed the title Checkout with GH_PAT token to hopefully fix releases Use GH_PAT token to hopefully fix releases Jul 26, 2024
@RobbieTheWagner RobbieTheWagner merged commit b09f0c2 into emberjs:main Jul 26, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants