Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using svg-jar #509

Merged
merged 4 commits into from
May 2, 2024
Merged

stop using svg-jar #509

merged 4 commits into from
May 2, 2024

Conversation

mansona
Copy link
Member

@mansona mansona commented May 2, 2024

svg-jar has some issues when consumed in a v2 addon, this PR will unblock us from merging ember-learn/guidemaker-ember-template#188

Copy link

netlify bot commented May 2, 2024

Deploy Preview for ember-styleguide ready!

Name Link
🔨 Latest commit c0c300c
🔍 Latest deploy log https://app.netlify.com/sites/ember-styleguide/deploys/6633c4e5b105d0000897bc7f
😎 Deploy Preview https://deploy-preview-509--ember-styleguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mansona mansona merged commit dba27d4 into master May 2, 2024
15 checks passed
@mansona mansona deleted the svg-jar branch May 2, 2024 17:01
@github-actions github-actions bot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants