Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move table of contents styling into concepts #492

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

MinThaMie
Copy link
Contributor

@MinThaMie MinThaMie commented Oct 20, 2023

Fixes #480
Screenshot 2023-10-20 at 14 28 16

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for ember-styleguide ready!

Name Link
🔨 Latest commit 1a7cba5
🔍 Latest deploy log https://app.netlify.com/sites/ember-styleguide/deploys/653a54b74fa78200087fb38a
😎 Deploy Preview https://deploy-preview-492--ember-styleguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MinThaMie MinThaMie force-pushed the table-contents-styling branch from ad6b4ad to add121d Compare October 20, 2023 12:28
@MinThaMie MinThaMie requested a review from mansona October 20, 2023 12:28
@MinThaMie MinThaMie self-assigned this Oct 20, 2023
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but it looks like the screenshot you shared is different from what I see 🤔 I don't seem to have any margin above the toc-heading elements:

Screenshot 2023-10-20 at 16 12 11

docs/concepts/table-of-contents.md Outdated Show resolved Hide resolved
@MinThaMie
Copy link
Contributor Author

You are correct :) not sure why locally this is not a problem, but I see where it comes from ;) Will try to remedy it without breaking the styling for api-docs

@MinThaMie MinThaMie requested a review from mansona October 26, 2023 12:02
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉

@mansona mansona merged commit bb6c36e into master Oct 26, 2023
13 checks passed
@mansona mansona deleted the table-contents-styling branch October 26, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move tabel of contents styling to styleguide
2 participants