Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Angle-Bracket Block-Rendered Components Parsed Incorrectly in 0.7.0 #473

Open
alexlafroscia opened this issue May 7, 2020 · 3 comments
Labels

Comments

@alexlafroscia
Copy link
Contributor

After updating to 0.7.0, some Markdown files that were previously parsed correctly no longer are.

We have a template like this:

## Simple Block Mode

{{#docs-demo as |demo|}}
  {{#demo.example name="fluid-select-simple-block-mode.hbs"}}
    {{#fluid-select
      select=(action (mut selectedFilter))
      options=filterOptions
      selected=selectedFilter
    as |select|}}
      {{select.trigger label="What kind of stuff?"}}

      {{#select.popup}}
        {{select.list}}
      {{/select.popup}}
    {{/fluid-select}}
  {{/demo.example}}
  {{demo.snippet "fluid-select-simple-block-mode.hbs"}}
{{/docs-demo}}

## Custom List

Rendering the fluid-select in this way was fine previously, but now fails; rendering it with non-angle-brackets in the "block" style messes with the way the rest of the file is parsed, so Custom List is no longer parsed as an h2.

If I convert the example code to use angle-bracket style invocation, the parsing seems to be fixed.

@alexlafroscia alexlafroscia changed the title Non-Angle-Bracket Block-Renders Components Parsed Incorrectly in 0.7.0 Non-Angle-Bracket Block-Rendered Components Parsed Incorrectly in 0.7.0 May 7, 2020
@RobbieTheWagner
Copy link
Member

Hmm, I am not sure what the problem might be here.

@alexlafroscia
Copy link
Contributor Author

Me neither 🤷 I tried narrowing it down but any time {{#fluid-select}} was rendered in that way, the parsing below that was thrown off.

Especially odd since the deployed Addon Docs docs for this addon uses the same syntax!

@RobbieTheWagner
Copy link
Member

I'm guessing it would have to be somewhere in the compile-markdown file. I do see this comment talking about handlebars and formatting https://github.com/ember-learn/ember-cli-addon-docs/blob/master/addon/utils/compile-markdown.js#L172-L173

Any chance you would have some time to debug? I would be happy to pair on it next week as well.

mixonic added a commit to Addepar/ember-table that referenced this issue Jan 27, 2021
* Add a dependency on ember-data since it no longer brings along the
  depenency.
* Add newlines to account for bugs in ember-cli-addon-docs. See:
  ember-learn/ember-cli-addon-docs#473 and
  ember-learn/ember-cli-addon-docs#402
* Add a missing `END-SNIPPET` without which parsing of the snippet was
  corrupted
mixonic added a commit to Addepar/ember-table that referenced this issue Feb 5, 2021
* Add a dependency on ember-data since it no longer brings along the
  depenency.
* Add newlines to account for bugs in ember-cli-addon-docs. See:
  ember-learn/ember-cli-addon-docs#473 and
  ember-learn/ember-cli-addon-docs#402
* Add a missing `END-SNIPPET` without which parsing of the snippet was
  corrupted
mixonic added a commit to Addepar/ember-table that referenced this issue Feb 5, 2021
New version of ember-cli-addon-docs bring a CSS reset which breaks
ember-table tests. Thus these libraries are updated, but only through
ember-try.

See the README for more information.

Other changes related to upgrading ember-cli-addon-docs include:

* Add a dependency on ember-data since it no longer brings along the
  depenency.
* Add newlines to account for bugs in ember-cli-addon-docs. See:
  ember-learn/ember-cli-addon-docs#473 and
  ember-learn/ember-cli-addon-docs#402
* Add a missing `END-SNIPPET` without which parsing of the snippet was
  corrupted
mixonic added a commit to Addepar/ember-table that referenced this issue Feb 5, 2021
New versions of ember-cli-addon-docs bring a CSS reset which breaks
ember-table tests. Instead of coupling the ember-table test suite to
ember-cli-addon-docs CSS, I created a new ember try config for
generating docs and removed the dependencies from the normal dev setup.

I've documented how to generate the documentation in the README.md, and
I believe updated the deployment/release code appropriately.

Other changes related to the ember-cli-addon-docs upgrade include:

* Add a dependency on ember-data since it no longer brings along the
  dependency.
* Add newlines to account for bugs in ember-cli-addon-docs. See:
  ember-learn/ember-cli-addon-docs#473 and
ember-learn/ember-cli-addon-docs#402
* Add a missing `END-SNIPPET` without which parsing of the snippet was
  corrupted.
* Make an `hbs` template executable without error.
mixonic added a commit to Addepar/ember-table that referenced this issue Feb 5, 2021
New versions of ember-cli-addon-docs bring a CSS reset which breaks
ember-table tests. Instead of coupling the ember-table test suite to
ember-cli-addon-docs CSS, I created a new ember try config for
generating docs and removed the dependencies from the normal dev setup.

I've documented how to generate the documentation in the README.md, and
I believe updated the deployment/release code appropriately.

Other changes related to the ember-cli-addon-docs upgrade include:

* Add a dependency on ember-data since it no longer brings along the
  dependency.
* Add newlines to account for bugs in ember-cli-addon-docs. See:
  ember-learn/ember-cli-addon-docs#473 and
ember-learn/ember-cli-addon-docs#402
* Add a missing `END-SNIPPET` without which parsing of the snippet was
  corrupted.
* Make an `hbs` template executable without error.
mixonic added a commit to Addepar/ember-table that referenced this issue Feb 5, 2021
New versions of ember-cli-addon-docs bring a CSS reset which breaks
ember-table tests. Instead of coupling the ember-table test suite to
ember-cli-addon-docs CSS, I created a new ember try config for
generating docs and removed the dependencies from the normal dev setup.

I've documented how to generate the documentation in the README.md, and
I believe updated the deployment/release code appropriately.

Other changes related to the ember-cli-addon-docs upgrade include:

* Add a dependency on ember-data since it no longer brings along the
  dependency.
* Add newlines to account for bugs in ember-cli-addon-docs. See:
  ember-learn/ember-cli-addon-docs#473 and
ember-learn/ember-cli-addon-docs#402
* Add a missing `END-SNIPPET` without which parsing of the snippet was
  corrupted.
* Make an `hbs` template executable without error.
mixonic added a commit to Addepar/ember-table that referenced this issue Feb 5, 2021
New versions of ember-cli-addon-docs bring a CSS reset which breaks
ember-table tests. Instead of coupling the ember-table test suite to
ember-cli-addon-docs CSS, I created a new ember try config for
generating docs and removed the dependencies from the normal dev setup.

I've documented how to generate the documentation in the README.md, and
I believe updated the deployment/release code appropriately.

Other changes related to the ember-cli-addon-docs upgrade include:

* Add a dependency on ember-data since it no longer brings along the
  dependency.
* Add newlines to account for bugs in ember-cli-addon-docs. See:
  ember-learn/ember-cli-addon-docs#473 and
ember-learn/ember-cli-addon-docs#402
* Add a missing `END-SNIPPET` without which parsing of the snippet was
  corrupted.
* Make an `hbs` template executable without error.
mixonic added a commit to Addepar/ember-table that referenced this issue Feb 5, 2021
New versions of ember-cli-addon-docs bring a CSS reset which breaks
ember-table tests. Instead of coupling the ember-table test suite to
ember-cli-addon-docs CSS, I created a new ember try config for
generating docs and removed the dependencies from the normal dev setup.

I've documented how to generate the documentation in the README.md, and
I believe updated the deployment/release code appropriately.

Other changes related to the ember-cli-addon-docs upgrade include:

* Add a dependency on ember-data since it no longer brings along the
  dependency.
* Add newlines to account for bugs in ember-cli-addon-docs. See:
  ember-learn/ember-cli-addon-docs#473 and
ember-learn/ember-cli-addon-docs#402
* Add a missing `END-SNIPPET` without which parsing of the snippet was
  corrupted.
* Make an `hbs` template executable without error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants