Skip to content

Commit

Permalink
Upgrade ember-cli-addon-docs and friends
Browse files Browse the repository at this point in the history
* Add a dependency on ember-data since it no longer brings along the
  depenency.
* Add newlines to account for bugs in ember-cli-addon-docs. See:
  ember-learn/ember-cli-addon-docs#473 and
  ember-learn/ember-cli-addon-docs#402
* Add a missing `END-SNIPPET` without which parsing of the snippet was
  corrupted
  • Loading branch information
mixonic committed Jan 27, 2021
1 parent a07e4c0 commit 48dcf11
Show file tree
Hide file tree
Showing 5 changed files with 4,962 additions and 3,004 deletions.
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
"ember-a11y-testing": "^0.5.0",
"ember-angle-bracket-invocation-polyfill": "^1.3.1",
"ember-cli": "~3.1.4",
"ember-cli-addon-docs": "0.6.13",
"ember-cli-addon-docs-yuidoc": "^0.2.1",
"ember-cli-addon-docs": "^1.0.0",
"ember-cli-addon-docs-yuidoc": "^1.0.0",
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-deploy": "^1.0.2",
"ember-cli-deploy-build": "^1.1.1",
Expand All @@ -66,6 +66,7 @@
"ember-cli-shims": "^1.2.0",
"ember-cli-sri": "^2.1.0",
"ember-cli-uglify": "^2.0.0",
"ember-data": "~3.12.0",
"ember-debug-handlers-polyfill": "^1.1.1",
"ember-disable-prototype-extensions": "^1.1.2",
"ember-export-application-global": "^2.0.0",
Expand All @@ -77,7 +78,7 @@
"ember-qunit": "^4.5.1",
"ember-radio-button": "^1.2.3",
"ember-resolver": "^5.1.1",
"ember-source": "~3.12",
"ember-source": "~3.12.0",
"ember-source-channel-url": "^1.0.1",
"ember-truth-helpers": "^2.0.0",
"ember-try": "^1.1.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export default Controller.extend({
{ name: 'K', valuePath: 'K' },
]);
}),
// END-SNIPPET

actions: {
toggleFixed(column) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ respective direction.
{{#demo.example name='scroll-indicators'}}
<div class="demo-container">
{{! BEGIN-SNIPPET docs-example-scroll-indicators.hbs }}

<EmberTable as |t|>
<t.head
@columns={{columns}}
Expand All @@ -33,6 +34,7 @@ them when they are present, or at the edges of the table when they are not.
{{#demo.example name='scroll-indicators-with-fixed'}}
<div class="demo-container">
{{! BEGIN-SNIPPET docs-example-scroll-indicators-with-fixed.hbs }}

<EmberTable as |t|>
<t.head
@columns={{columnsWithFixed}}
Expand All @@ -47,6 +49,7 @@ them when they are present, or at the edges of the table when they are not.
{{demo.snippet name='docs-example-scroll-indicators-with-fixed.hbs'}}
{{demo.snippet name='docs-example-scroll-indicators-with-fixed.js' label='component.js'}}
{{/docs-demo}}

## Vertical Scroll Indicators with a Header & Footer

Vertical scroll indicators respect both headers and footers, appearing just
Expand All @@ -56,6 +59,7 @@ inside any sticky rows at the top or bottom of the table.
{{#demo.example name='scroll-indicators-with-footer'}}
<div class="demo-container">
{{! BEGIN-SNIPPET docs-example-scroll-indicators-with-footer.hbs }}

<EmberTable as |t|>
<t.head
@columns={{columnsWithFooter}}
Expand Down
6 changes: 5 additions & 1 deletion tests/dummy/app/pods/docs/guides/header/sorting/template.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ you want to sort the content of the table asynchronously, you can unset the
`sortFunction` and handle the async request yourself.

```hbs
{{ember-thead sortFunction=null}}
<EmberTable as |t|>
<t.head
sortFunction=null
/>
</EmberTable>
```

## Disabling Sorting
Expand Down
Loading

0 comments on commit 48dcf11

Please sign in to comment.