fix compatibility with ember-data 5

ember-learn · Dec 20, 2023 · dffddfa · dffddfa
1 parent 5c7eb86
commit dffddfa
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 4 deletions.
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
@@ -98,6 +98,7 @@ jobs:
         try-scenario:
           - 'ember-lts-4.4'
           - 'ember-lts-4.8'
+          - 'ember-lts-5.4'
           - 'ember-release'
           - 'ember-beta'
           - 'ember-canary'

diff --git a/addon/models/class.js b/addon/models/class.js
@@ -3,7 +3,7 @@ import { filterBy, or, union } from '@ember/object/computed';
 import { memberUnion, hasMemberType } from '../utils/computed';
 
 export default class Class extends Model {
-  @belongsTo('class', { async: false, inverse: null })
+  @belongsTo('class', { async: false, inverse: null, polymorphic: false })
   parentClass;
 
   isClass = true;

diff --git a/addon/models/module.js b/addon/models/module.js
@@ -10,10 +10,10 @@ export default class Module extends Model {
   @attr
   functions;
 
-  @hasMany('class', { async: false, inverse: null })
+  @hasMany('class', { async: false, inverse: null, polymorphic: true })
   classes;
 
-  @hasMany('class', { async: false, inverse: null })
+  @hasMany('class', { async: false, inverse: null, polymorphic: true })
   components;
 
   /*

diff --git a/addon/models/project.js b/addon/models/project.js
@@ -13,6 +13,6 @@ export default class Project extends Model {
   @attr
   navigationIndex;
 
-  @hasMany('module', { async: false, inverse: null })
+  @hasMany('module', { async: false, inverse: null, polymorphic: false })
   modules;
 }
diff --git a/tests/dummy/config/ember-try.js b/tests/dummy/config/ember-try.js
@@ -23,6 +23,15 @@ module.exports = async function () {
           },
         },
       },
+      {
+        name: 'ember-lts-5.4',
+        npm: {
+          devDependencies: {
+            'ember-data': '~5.3.0',
+            'ember-source': '~5.4.0',
+          },
+        },
+      },
       {
         name: 'ember-release',
         npm: {