Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 404 #905

Conversation

MehulKChaudhari
Copy link

Fixes: #884
Desktop version:
image

Mobile Version:
image

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for ember-api-docs ready!

Name Link
🔨 Latest commit c7519ce
🔍 Latest deploy log https://app.netlify.com/sites/ember-api-docs/deploys/65c8a4e893e66a000852b7bd
😎 Deploy Preview https://deploy-preview-905--ember-api-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MehulKChaudhari
Copy link
Author

Hey @MinThaMie, Could you please review this PR?

@MinThaMie
Copy link
Contributor

MinThaMie commented Feb 14, 2024

Hey, thanks for the work you did, I'm sorry I did not do a better job at pointing you to the right starting branch. Our website-redesign (#868) branch should be your starting point and no longer uses scss. I hope you don't mind changing that. If you do, please let me know so I can port your changes there. It looks good, on mobile I would prefer a bit of margin around the image :)

@MehulKChaudhari
Copy link
Author

Hey, thanks for the work you did, I'm sorry I did not do a better job at pointing you to the right starting branch. Our website-redesign (#868) branch should be your starting point and no longer uses scss. I hope you don't mind changing that. If you do, please let me know so I can port your changes there. It looks good, on mobile I would prefer a bit of margin around the image :)

Sure no worries, I will make the changes.

@MehulKChaudhari
Copy link
Author

MehulKChaudhari commented Feb 15, 2024

Closing this PR will be raising new with website-redesign as base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement 404
2 participants