Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint/remark frail #80

Merged
merged 3 commits into from
Dec 13, 2018
Merged

lint/remark frail #80

merged 3 commits into from
Dec 13, 2018

Conversation

maxwondercorn
Copy link
Contributor

Added --frail option to npm run lint:md so linting issues will throw errors in CI.

  • Bumped ember-dictionary version
  • Linted and edited README.md and CONTRIBUTING.md for consistency with the rest of the guides

This PR based on discussion in #79.

@maxwondercorn
Copy link
Contributor Author

Sorry for the confusing PR. Reused the dead links linting branch, cleaned it up and created a new PR from it.

package.json Outdated Show resolved Hide resolved
@jenweber jenweber merged commit 59d42ce into ember-learn:master Dec 13, 2018
@jenweber
Copy link
Contributor

Thank you! I ran this locally and it looks great. Merged.

@maxwondercorn
Copy link
Contributor Author

Would you like me to implement this on the other guides?

@maxwondercorn maxwondercorn deleted the lint/remark-frail branch December 13, 2018 04:32
@jenweber
Copy link
Contributor

That would be awesome! Is there a way for us to run these tests on the diff of new PRs only? The Guides are massive and will have a thousand things to spellcheck or add as exceptions.

@maxwondercorn
Copy link
Contributor Author

Not sure, I'd have to look into it to see what's possible. The worst case for spell checking would be the initial setup. It would catch the technical words that aren't already in the dictionary. I'd think I got most of the potential words in the dictionary based on the cli-guides. After that it would only be checking PRs.

For the ember guides proper, you'd only spell check the current release and upcoming release guides. All earlier versions would be put into the ignore file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants