Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --typescript option to generate command docs #312

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

achambers
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for ember-cli-guides ready!

Name Link
🔨 Latest commit 828ade8
🔍 Latest deploy log https://app.netlify.com/sites/ember-cli-guides/deploys/654e53c4732f1000081a1d2d
😎 Deploy Preview https://deploy-preview-312--ember-cli-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ef4
Copy link

ef4 commented Dec 1, 2023

We have a review already, but this is still blocked, do we need an explicit @ember-learn/learning-core-team approval?

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mansona mansona merged commit 92bb960 into ember-learn:main Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants