Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all command line options for ember test, serve, and generate #276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arafatiqbal
Copy link

#251

Would love to get feedback on this. I'm not in love with this approach, but I can see how it could be helpful for people to see all command line options for ember test, serve, and generate

Please feel free to drop feedback, I'm open to other suggestions on how to do this.

@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for ember-cli-guides ready!

Name Link
🔨 Latest commit e206830
🔍 Latest deploy log https://app.netlify.com/sites/ember-cli-guides/deploys/63982a27255ba30008af9ff2
😎 Deploy Preview https://deploy-preview-276--ember-cli-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MinThaMie MinThaMie requested a review from bertdeblock February 8, 2023 09:28
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) I've also asked somebody from the CLI core team to take a look!

@bertdeblock
Copy link
Collaborator

We already list the output of these commands on https://cli.emberjs.com/release/advanced-use/cli-commands-reference/.
Reading #251, I also think it would be better to list them in the .ember-cli file as an example. Though, the available options are not only limited to the ember generate, ember serve and ember test commands. I think it applies to all commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants