Upgrade Ember CLI to 5.4 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolmaus
force-pushed
the
ember-5-upgrade
branch
3 times, most recently
from
e7b1710
to
24dd408
Compare
Merged
1 task
mansona
requested changes
Nov 23, 2023
.github/workflows/ci.yml
Outdated
| ember-lts-2.18, | ||
| ember-lts-3.16, | ||
| ember-lts-3.20, | ||
| ember-lts-3.24, |
There was a problem hiding this comment.
undo these removals, they should be removed in a separate PR 👍
.github/workflows/ci.yml
Outdated
| ember-lts-3.28, | ||
| ember-lts-4.4, | ||
| ember-lts-4.8, | ||
| ember-lts-4.12, | ||
| ember-lts-5.3, |
There was a problem hiding this comment.
so either 5.3 needs to just be removed or we bump it to 5.4. technically 5.4 isn't an LTS until 5.5 is released so maybe we just remove for now since the "normal" test (not with ember-try) is already testing 5.4 👍
| 'ember-source': '~3.24.3', | ||
| }, | ||
| }, | ||
| }, |
| @@ -1,11 +1,11 @@ | |||
| /* globals self */ | |||
| /* globals require Ember */ | |||
There was a problem hiding this comment.
undo all changes in this file for prettier. This is not needed as it will be deleted shortly. reset it back to master/main and use eslint-disable to ignore warnings 👍
lolmaus
force-pushed
the
ember-5-upgrade
branch
2 times, most recently
from
7fa05e5
to
fe7f7f3
Compare
Keep original versions of ci.yml, ember-try.js and readme
lolmaus
force-pushed
the
ember-5-upgrade
branch
from
fe7f7f3
to
1c7e288
Compare
mixonic
reviewed
Dec 20, 2023
| 'ember-source': '~5.3.0', | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
5.3 here was just a placeholder until there was a 5.x lts
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via
ember-cli-update. Kept original versions ofci.yml,ember-try.jsand readme.