Add support for replacing in backticks strings in JS #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patocallaghan
added a commit
to intercom/broccoli-asset-rewrite
that referenced
this pull request
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for rewriting asset paths in Javascript template literals (a.k.a backtick strings). This includes some† support for string interpolation. It is intended to address the issue reported here: #66
† I've added support for what seemed like the most common cases of string interpolation: variables and property access, method calls, method calls with strings, array index access. As far as I know any valid JS expressions could go in a string interpolation, so that could include arrow functions and other complicated structures. The updated regex section accepts any characters except the closing brace
}so potentially it might not match on a line with a complicated string interpolation.