Disallow SAI start without an initial write #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elagil
commented
Nov 16, 2024
| @@ -828,7 +828,6 @@ impl<'a, W: Word> ReadableRingBuffer<'a, W> { | |||
| /// You must call this after creating it for it to work. | |||
| pub fn start(&mut self) { | |||
| self.channel.start(); | |||
| self.clear(); | |||
There was a problem hiding this comment.
Clear on start conflicts with write_immediate. With clear in place, write_immediate would have no effect.
Dirbaio
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when starting the SAI (and its ring buffer + DMA channel), then writing data to the ring buffer later, the SAI DMA has already been running for some (undeterministic) amount of time. It only makes sense to start the DMA after there is already data in the transmit ring buffer present.
This PR disables
startfor SAI in transmit mode, and starts the DMA just after the transmit ring buffer was filled with an initial amount of data.