Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building executor on v1.82 xtensa toolchains #3525

Closed
wants to merge 1 commit into from

Conversation

wetheredge
Copy link
Contributor

This is a followup for #3508 that does not rely on the compiler build date, since the Xtensa toolchain's build dates don't match the official ones. In particular, the Xtensa 1.82 releases were built in late October, but still have the old api.

@wetheredge wetheredge marked this pull request as draft November 12, 2024 00:36
@Dirbaio
Copy link
Member

Dirbaio commented Nov 12, 2024

cc @bugadani

could you guys clarify which xtensa compiler versions are out there affected by this? which ones were covered by #3508 and which ones did it miss that this PR is now covering?

I'm thinking that maybe we're overcomplicating this and we should just make it unconditionally use the stable WakerHack even if nightly feature is enabled.

@bugadani
Copy link
Contributor

bugadani commented Nov 12, 2024

Eh yeah I forgot that our compiler is built as a nightly, from the stable branch, so I guess it worked for 1.81 because it was built on the 3rd of September, before the change landed - but 1.82 was already branched off at that point.

I'd prefer this PR over WakerHack as I think safety: OK because WakerHack has the same layout as Waker is incidental and not guaranteed to not change randomly. I guess using WakerHack should be okay, and 1.83 is close also.

@Dirbaio
Copy link
Member

Dirbaio commented Nov 12, 2024

Fixed in #3528

@Dirbaio Dirbaio closed this Nov 12, 2024
@wetheredge wetheredge deleted the executor-esp-1.82 branch November 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants