feat: stm32 gpdma readable ringbuffer #3480
Open
+423
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on previous work: #2059 by @tyler-gilbert and #3162 by @caleb-garrett and mainly aims to make the ringbuffered usart work with gpdma targets. I've only removed the gpdma feature gates around usart since it was what I could test and validate.
The original PR's did contain a writable ringbuffer, but since I won't able to validate if it works, it is left out for a future PR when relevant.
I've also included a test for it and also have tried to not break existing modules depending on the current
RingBuffer(since there was need to change the dma irq)Finally, I think it would be interesting to create a new trait for the Gpdma ringbuffers, since they each are used mostly interchangeably and it 'just works' because all of the implementations have the same functions. An example of this issue would be the
request_suspendmethod which was missing at first from @tyler-gilbert 's implementation but is used by the ringbuffered usart implementation.@Dirbaio could you review this?