Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options for the mypy pylsp plugin #4370

Conversation

LaurenceWarne
Copy link
Contributor

Hi! This PR adds configuration options for the mypy pylsp plugin, documented at https://github.com/python-lsp/pylsp-mypy. Configuration using LSP is not documented (yet 🙂), but appears to be supported - I've tested most of the options locally.

Add configuration options for the mypy pylsp plugin, documented at
https://github.com/python-lsp/pylsp-mypy.
@github-actions github-actions bot added the client One or more of lsp-mode language clients label Mar 15, 2024
Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yyoncho yyoncho merged commit 782e1dc into emacs-lsp:master Mar 17, 2024
11 of 14 checks passed
@LaurenceWarne LaurenceWarne deleted the add-mypy-plugin-configuration-options-for-pylsp branch March 17, 2024 21:07
@jcs090218
Copy link
Member

jcs090218 commented Mar 18, 2024

I overlooked a warning, see https://github.com/emacs-lsp/lsp-mode/actions/runs/8295196871/job/22701748075#step:12:503. 🤔

lsp-pylsp.el:477:2: Warning: custom-declare-variable `lsp-pylsp-plugins-mypy-dmypy' docstring has wrong usage of unescaped single quotes (use \= or different quoting)

@LaurenceWarne
Copy link
Contributor Author

Sorry again: #4381!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants