WIP: CI: enable check for lack of new warnings while byte-compiling #1860
Conversation
|
I sent the "warning fix" commit separately at #1861 to have the fix in tree while the discussion here is ongoing. |
Hi-Angel
force-pushed
the
fix-warnings
branch
from
6344e96
to
7af8a5a
Compare
There's no point in this warning, because it is defined and processed
inside evil-mode. The warning only matters for user-side usage. So
disable it here.
Fixes:
evil-types.el:96:22: Error: ‘evil-want-visual-char-semi-exclusive’ is an obsolete variable (as of 1.15.0); Semi-exclusivity prevents selecting text + 1st char of next line,
without having to introduce new niche functionality.
Hi-Angel
force-pushed
the
fix-warnings
branch
2 times, most recently
from
93265e9
to
9f68edd
Compare
|
Weird… so, I fixed everything, but on the older Emacs'es it fails with "undo-redo" undefined. The problem is that it is defined, I put a UPD: reported a bug https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69290 |
Hi-Angel
force-pushed
the
fix-warnings
branch
6 times, most recently
from
61cd109
to
7726a9e
Compare
Fixes warnings like:
evil-commands.el:5205:1:Error: the following functions are not known to be defined: string-trim-right, tab-bar-close-tab, tab-close, tab-bar-select-tab, tab-bar-switch-to-next-tab
It is part of the newer Emacs, but on the older ones it causes warnings. There's no tests of that functionality, so just suppress the warning.
As part of that we test with latest released Emacs version rather than snapshot, because we don't want CI to start suddenly failing on unrelated changes because upstream introduced a new warning/check.
Hi-Angel
force-pushed
the
fix-warnings
branch
from
7726a9e
to
8965783
Compare
|
Okay, I think I'm done for now, I just don't have anymore resources, this is utter chaos. In some versions some functions were in one or another file. This fail I don't even understand. It claims to not have found |
This fixes one warning and adds a check that makes sure that CI will fail if a pull-request contains byte-compilation errors. As part of that we replace "emacs-snapshot" in CI with the latest released one because it's "frozen in time", while depending on snapshot may result in CI failing just because upstream introduced new warnings.
This is WIP because: there's one "deprecation warning" which Idk what to do about, because it's internal in Evil. It sounds like:Thoughts? One possible solution is to disable check for "deprecation warnings", but then we will miss new deprecations from upstream.
P.S.: the changes in Makefile also result in a wall of weird messagesMakefile:34: warning: overriding recipe for target 'evil-search.elc'. I would be very grateful if someone points out how to fix that because I'm not that good in Makefiles (I usually migrate everything I maintain to Ninja or Meson) and Makefiles often behave weirdly.