Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(org): update load, declare-function #847

Closed
wants to merge 2 commits into from
Closed

fix(org): update load, declare-function #847

wants to merge 2 commits into from

Conversation

bdarcus
Copy link
Contributor

@bdarcus bdarcus commented Oct 26, 2024

In Emacs 31, org-element-property and org-element-type has been moved to a new file: org-element-ast.

Update code to handle this properly, depending on version.

@bdarcus bdarcus force-pushed the fix-102624 branch 4 times, most recently from 98060ce to abdd5c0 Compare October 26, 2024 11:38
@bdarcus
Copy link
Contributor Author

bdarcus commented Oct 26, 2024

@yantar92 - this little PR is me trying to update citar to accommodate you moving a couple of functions to org-element-ast, but my CI is complaining about the code I have here. Any suggestions for fixing it?

@yantar92
Copy link

@bdarcus
Copy link
Contributor Author

bdarcus commented Oct 26, 2024

Right, but how do I do it conditionally? I still have to use org-element for earlier versions.

This PR attempts that, but the CI is complaining.

@yantar92
Copy link

I suspect that you cannot do it conditionally. You may consider using ext:, which will suppress CI failures.

In Emacs 31, org-element-property and org-element-type have moved to
a new file: org-element-ast.

Update code to handle this properly, depending on version.

Signed-off-by: Bruce D'Arcus <[email protected]>
* Define citar-org-cite-basic-activate

citar-org-cite-basic-activate is an org-cite activate processor meant to
be a more performant version of org-cite-basic-activate

* feat(org): Use the citar-org-cite-basic-activate activate processor by default

Previously, citar-org-activation-functions used the built-in
org-cite-basic-activate` processor. Now, we use citar-org-cite-basic-activate
by default instead.

* docs(org): Update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants