-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger: Grouping msg #77
Conversation
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
@evancz
|
Seems like CSS is messed up. I've already found the cause. Will be fixed soon. |
Oh, I forgot to mention the trade-off of this implementation. Unlike before, the number of messages in a snapshot is flexible now. If all messages belong the same group, the snapshot will be infinitely growing. For example, just seeing 60fps game 10 seconds will make 600 messages. So unlucky user may have a very bad performance. That said, I guess the current state of such game development is "cannot do any debugging". I think getting more feedback from them is higher priority. The workaround would be |
I wouldn't do more optimization on groups for now. If you have better tests, swap them in. |
Done. I found a workaround for package conflicts, so it is no problem. |
.travis.yml
Outdated
node_js: | ||
- "4.2" | ||
before_script: | ||
- npm install -g elm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generally best pin this to the current version, e.g. npm install -g [email protected]
- otherwise these tests will start failing once 0.19 is released.
Granted, it's safe to assume this particular library will be updated before that happens, but some people will probably copy/paste from this config, so it'd be nice to them if this did the better thing. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I actually did copy/paste from somewhere. Just updated!
I will close this because this is outdated. It would be great if this debugger supports grouping, model diffing and other things like that, but I cannot spend my time to do them. Also, I felt a lot of pressure to break official tool and respond to everyone's needs. So I think it's far easier for me to maintain my code for my purpose. I will plan another way to contribute to Elm. Sorry ;) |
This PR adds "Grouping messages" feature to the debugger.
(Most of discussion are done with Evan.)
Group by sequence of constructors
These four are grouped by “ComponentMsg … Transition”, only seeing the constructors and skipping any other information.
Only frequent messages are hidden
The open/close state for each group is automatically determined.