Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: transparent background #78

Closed
mxkrsv opened this issue Nov 16, 2021 · 9 comments
Closed

Feature request: transparent background #78

mxkrsv opened this issue Nov 16, 2021 · 9 comments

Comments

@mxkrsv
Copy link

mxkrsv commented Nov 16, 2021

Original gruvbox had gruvbox_transparent_bg option for that.

@sQVe
Copy link
Contributor

sQVe commented Nov 16, 2021

This is, as far as I know and according to the readme, already supported. All options of the original gruvbox is.

Edit: or maybe it isn't. 🤷‍♂️

@mxkrsv
Copy link
Author

mxkrsv commented Nov 16, 2021

Well, I just got that I saw this option in morhetz/gruvbox#287, not in gruvbox itself. However, it's pretty useful as it's the only way to do transparent background, because any "highlight <...>" commands in init.lua don't take effect.

@gmr458
Copy link

gmr458 commented Nov 22, 2021

Try this and it doesn't work, it would be great to have this feature or if it's already added why doesn't it work? Am I doing something wrong?
image

@mxkrsv
Copy link
Author

mxkrsv commented Nov 22, 2021

Try this and it doesn't work, it would be great to have this feature or if it's already added why doesn't it work? Am I doing something wrong? image

My PR isn't merged yet, so for solution on line 82 to work you'll have to apply my patch manually or to clone my PR's branch. Line 86 doesn't work at all, and that's the reason why I did this PR.

@ellisonleao
Copy link
Owner

Sorry guys, the original repo and the community version on which this repo is based does not have that option so I would recommend for you guys that still want that behaviour to add the config manually in your configs.

@timsofteng
Copy link

Try this and it doesn't work, it would be great to have this feature or if it's already added why doesn't it work? Am I doing something wrong?
image

Hello. How did you achieve this italic font rendering?

@gmr458
Copy link

gmr458 commented Apr 4, 2022

@timsofteng Font Dank Mono Regular and Italic

@timsofteng
Copy link

@timsofteng Font Dank Mono Regular and Italic

I mean how to force gruvbox.nvim to display italic in cases as on your screenshot?
My main font is source code pro and I have full bundle including italic mono one. But in same case it render regular mono.

@ellisonleao
Maybe you have ideas?

And I still don't understand how to enable transparent background.

@gmr458
Copy link

gmr458 commented Apr 6, 2022

@timsofteng find all options that have "italic" in the name with Ctrl+f in the browser. https://github.com/morhetz/gruvbox/wiki/Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants