Relax requirements for hasonefield #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi guys, is this ready to be merged? |
|
The title of the PR says WIP, so I'd say no at this stage. @elliot-sawyer would you have an update here? Did it work for you to relax the requirements? |
|
Apologies for the delays, I've had very little time to focus on the module recently. If I recall the reason for the restriction was due to an upstream issue that is now fixed., so it's probably OK. Will check as soon as I get a chance to |
|
Thanks for that!
…On Tue, Mar 15, 2022, at 14:22, elliot sawyer wrote:
Apologies for the delays, I've had very little time to focus on the module recently. If I recall the reason for the restriction was due to an upstream issue that is now fixed., so it's probably OK. Will check as soon as I get a chance to
—
Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACIJV3NQWOD5B534IDAJ2DU77655ANCNFSM5KMODQAA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Been testing this regularly on modern builds, I think it's fine to merge |
elliot-sawyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix Issue #30