Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#26] Disabled LinkField class's save logic #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakxnz
Copy link

@jakxnz jakxnz commented May 11, 2021

#26

@elliot-sawyer
Copy link
Owner

Thanks for this @jakxnz !

I think there's a bigger issue here - why is LinkField not saving properly using the methods inherited from FormField? I'm not sure that telling LinkField to never save into a DataObject is the best solution. I agree with @GuySartorelli, we need some better reproduction steps.

That aside, I can't merge this in until the conflicts are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants