11 interactive mode dev #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -i/--interactive flag to enable users to send custom AT commands in interactive mode. This enhances the CLI flexibility by allowing direct AT command input during runtime.
Add new functionality to support interactive AT command sessions: - Implement get_interactive_command() for user input validation - Add handle_interactive_session() to manage interactive command flow - Update start_process() to support both batch and interactive modes - Add interactive flag parameter to control execution mode This enhancement allows users to manually enter and execute AT commands in an interactive session while maintaining the existing batch mode functionality.
Add comprehensive test suite for interactive AT command mode including: - Test cases for get_interactive_command() with valid/invalid inputs - Coverage for handle_interactive_session() with command sequences - Tests for start_process() in both interactive and standard modes - Validation of command processing and status file creation This enhances test coverage for the interactive CLI features and ensures proper handling of user input scenarios.
- Pass interactive flag to core function in cli.py - Bump version from 0.1.4 to 0.1.5
- Add consistent trailing commas in function parameters - Fix string quote style in test files (single -> double quotes) - Improve readability of long function calls by breaking into multiple lines - Format CLI argument definitions consistently - Clean up whitespace in docstrings and function signatures The changes focus on code style consistency across the codebase, particularly in sierra_status/src and tests directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a new feature to support interactive mode to send by user AT command and save to log file.
The code is used with the existing design and added the relevant functions to support it in both usb_handle.py and cli.py.
adding test methods to cover additional methods and functionality.
the new version test on WIndows and Linux.
close issue #11