Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardize ACTION_INTERVAL unit to minutes in twitter client #1738

Merged
merged 5 commits into from
Jan 4, 2025

Conversation

sin-bufan
Copy link
Contributor

Relates to:

Related to inconsistent time unit usage for ACTION_INTERVAL across the codebase.

Risks

Low - This is a documentation and logging clarity improvement that doesn't change core functionality.

Background

What does this PR do?

Standardizes the ACTION_INTERVAL unit to consistently use minutes across:

  1. Environment variable documentation
  2. Log messages in Twitter client
  3. Internal time calculations

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

  • Fixes inconsistent time unit usage that could cause confusion

Documentation changes needed?

My changes require a change to the project documentation.

  • Updated env.example to clarify ACTION_INTERVAL uses minutes

Testing

Where should a reviewer start?

Review the Twitter client post processing code: packages/client-twitter/src/post.ts

Detailed testing steps

  1. Set ACTION_INTERVAL in .env file
  2. Start Twitter client
  3. Verify log messages correctly display intervals in minutes
  4. Confirm action processing occurs at expected minute intervals

Discord username

sin_bufan

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shakkernerd shakkernerd merged commit b79cd60 into elizaOS:develop Jan 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants