-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add advanced trading #1340
base: develop
Are you sure you want to change the base?
Conversation
is the goal to convert this to typescript? |
yessirEl dic 21, 2024, a la(s) 19:40, chris ***@***.***> escribió:
is the goal to convert this to typescript?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
hey fam, thank you for reviewing. please lmk if it is necessary to convert to typescript prior to a PR. all of my quant stuff is in python but im willing to learn ts and convert it if needed also the integration tests are failing due to the need of api keys: birdeye, helius rpc and solana private key. is there a secure way i can send mine? im @moondev on discord cheers |
Hey @moondevonyt good stuffs! I would need to do an extensive test and also bring it up with other team members before deciding if port to typescript or not (I might be able to help and support if that will be the case though). Also, the integration tests failure is due to script not finding the OPEN API key (not from your end). |
hey @shakkernerd thank you very much for your help w review and ts. tomorrow i was planning on building a python shell to make it all useable from typescript, but i would be curious do you think it is a better use of time doing that, or re-writing in ts? i have a ton to contribute from the quant side, virtually all in python so i will do whatever is needed to be done to allow the agents to leverage my libraries thank you sir |
sup fam, today i put in a few hours to extend the Eliza framework by adding some core trading functionality for on-chain solana bots. my focus was to create a set of tools that will allow agents to execute trades, manage risk, and pull critical data. here's what I added and worked on:
What I Added/Completed Today:
Why This Matters:
What's Next?
Thanks for the opportunity to contribute. Let me know if there’s anything you’d like me to adjust or refine for tomorrow.