fix: fix imageModelProvider apiKey selection fallback #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UD1sto
changed the title
|
Closed to review again and remediate issues |
|
+1 to this pull request. Looking to add another image gen provider but waiting for this pull to fix an underlying issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Relates to
#1270
##Risks
None known
What does this PR do?
Introduces an addition on packages/core/src/generate.ts that first tries to match the apiKey to it's corresponding imageModelProvider and moves to the fallback logic if that fails.
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Why are we doing this? Any context or related work?
Current behaviour is not intended and causing issues and confusion.
Documentation changes needed?
Testing
Manually tested
Where should a reviewer start?
packages/core/src/generate.ts
Detailed testing steps
Deploy Notes
Database changes
Discord username