Add support for per_page param #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I'm getting the impression this lib maybe dead. I've started to try and bring some new life into it here https://github.com/MorphicPro/dissolver The two biggest features I've added to this thus far are custom theme modules and lazy queries. In the case of lazy queries paginate returns an Ecto query rather than calling Repo.all I've rebuilt a good part of the main lib but I'm still in the process of rewriting the specs for the Paginator since I don't want it to have so much open API. |
+ bump Plug from 1.4.3 to 1.7.2 since PhoenixHTML requires ~> 1.5
Bump PhoenixHTML from 2.10.4 to 3.3.1
Add a formatter and format the project
The application inference added in that version fixes all the warnings related to dependencies list and applications list :)
Bump Elixir requirement from 1.2 to 1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having no way to control the
per_pageoutside of theuse Kerosene, per_page: 10is a feature that I just couldn't live without. So here is the basic implementation of that.This also brings back the PR #24, with a small twist – now to "disable" pagination via params just pass
"per_page" => "all"(since that makes more sense thannil) :>