Feature/error boundary #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikHorn
requested review from
toschmidt,
FabianWildgrube,
AlexanderZellner,
maxammann,
ricffb and
SimonKostin98
toschmidt
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorBoundary component/HOC wrapper can be used to prevent unlimited (Runtime-) Error propagation through the DOM tree. By default, any error will bubble up the entire DOM tree and take down the application, causing a blank white page to be rendered. ErrorBoundary components catch all errors, log them and prevent further bubbling by replacing their DOM subtree with a visual error message. This enhances usability for end users and developers alike.
I am unsure whether or not to designate an entire package to this component. Opinion @schmitob?
close #15