Copy notebook exports via nb header #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elis
reviewed
Aug 15, 2021
| @@ -57,6 +58,9 @@ export const NotebookHeader = (props) => { | |||
| const [state, actions] = useNotebook() | |||
| const [documentMenuVisible, setDocumentMenuVisible] = useState() | |||
|
|
|||
| let exports = [] | |||
There was a problem hiding this comment.
Okay, so it has to be declared as an array, so that the exports can be iterated over. I will change it up though
| @@ -291,6 +297,57 @@ export const NotebookHeader = (props) => { | |||
| // { hasMain, notebook, userProfile, notebookId, isOwner } | |||
| // ) | |||
|
|
|||
| const fallbackCopyTextToClipboard = (text) => { | |||
There was a problem hiding this comment.
I'd extract this entire logic into a separate function or a custom hook - and i'd also check if there's a copy-to-clipboard package to use instead of hand-crafting it
| } | ||
|
|
||
| const initCopy = () => { | ||
| let exportsAsString = '' |
There was a problem hiding this comment.
I'd prepare the string in advanced so it can be shown to the user - this can be a large blob of text on some occasions and not necessarily what the user expects.
- Added a modal where you can choose which exports - Now only shows # of exports - Copy is using an NPM package
elis
reviewed
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as already approved PR, but much better functionality and looks