Support fast_float 7.0.0 #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release changes `chars_format` from an `enum` to an `enum class` with underlying type `uint64_t`. https://github.com/fastfloat/fast_float/releases/tag/v7.0.0
|
I considered the suggestion in #135 (comment), and it is much cleaner for 7.0.0, but as noted in #135 (comment), it’s not quite backwards-compatible. |
This type is not supported in fast_float: fastfloat/fast_float#88. As of fast_float 7.0.0, trying to parse long doubles with fast_float results in a compiler error rather than selecting the wrong overload: eliaskosunen#135 (comment).
musicinmybrain
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 8 8
Lines 5601 5601
=======================================
Hits 4485 4485
Misses 1116 1116 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not quite work yet.See https://github.com/fastfloat/fast_float/releases/tag/v7.0.0 and discussion in #135.