Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Explain text predictions of Keras classifiers #10

Open
wants to merge 164 commits into
base: master
Choose a base branch
from
Open

[WIP] Explain text predictions of Keras classifiers #10

wants to merge 164 commits into from

Conversation

lopuhin
Copy link
Contributor

@lopuhin lopuhin commented Jan 23, 2021 •
edited
Loading

TeamHG-Memex/eli5#325 by @teabolt

TODO:

  • make sure build is passing
  • double-check if anything needs to be updated / adjusted

teabolt and others added 30 commits July 1, 2019 16:19
@teabolt
WeightedSpan commment
8196243
@teabolt
End-to-end simple text (breaks image)
ef63e5a
@teabolt
Merge branch 'keras-gradcam-img' of https://github.com/teabolt/eli5 i…
1774ac8 
…nto keras-gradcam-text
@teabolt
Fix image explanations ('regression')
ccdba2b
@teabolt
Merge branch 'keras-gradcam-img' of https://github.com/teabolt/eli5 i…
d94f553 
…nto keras-gradcam-text
@teabolt
New args for text explanations (mypy and docstring)
a7c7e74
@teabolt
Move span builder code to function. Add construct_document function
efb417b
@teabolt
Refactor and generalize _validate_doc
a2d18d5
@teabolt
Refactor _get_activation_layer. Add layer condition for text
8dd2579
@teabolt
Comment about WeightedSpan
774b812
@teabolt
Disable validation of retrieved activation_layer
633dc4c
@teabolt
Add comment about counterfactual explanations
3dabdd3
@teabolt
Add compute_weights to keras package
d37016c
@teabolt
Merge branch 'keras-gradcam-img' of https://github.com/teabolt/eli5 i…
b8c979e 
…nto keras-gradcam-text
@teabolt
Add post-padding removal
a781e66
@teabolt
Put text and image explanation code into separate functions
723e98d
@teabolt
Add function to upsize 1D arrays
3bb13db
@teabolt
Comment about scipy resample, K.gradients
d6a23bd
@teabolt
Add relu and counterexplanation args
4024be0
@teabolt
Update lib docs, docstring (heatmap and explanation details)
30ed0c8
@teabolt @kmike
Update tests/utils_image.py (use count_nonzero instead of sum)
b89b65a 
Co-Authored-By: Mikhail Korobov <[email protected]>
@teabolt
Hardcoding to explain RNN's (with rank 1 activations)
37bfb47
@teabolt
Merge branch 'keras-gradcam-img' of https://github.com/teabolt/eli5 i…
049aaca 
…nto keras-gradcam-text
@teabolt
Fix failing tests for image explanations
6a4e1ae
@teabolt
Fix mypy for image explanations
74cb56d
@teabolt
Comments
28c2ac2
@teabolt
Fix image docs. Run tutorial notebook in update script
1e0bbba
@teabolt
Comment about running sections of notebook script
3beb7ca
@teabolt
Make image arg required for image-based explanations
58f0108
@teabolt
Update image tutorial to use image arg
379abfc
teabolt and others added 25 commits September 7, 2019 20:29
@teabolt
Rename function. Add tests for package imports
69fe751
@teabolt
Move argument validation to relevant modules
9788c22
@teabolt
Separate out classification-specific code into a function
18980b7
@teabolt
Replace mypy annotation K.variable with Any
6cfd526
@teabolt
Add validation for public function arguments
c94eb52
@teabolt
Merge branch 'master' of github.com:teabolt/eli5 into keras-gradcam-text
6e960ff
@teabolt
Fix error formatting in eli5.nn.gradcam
881d607
@teabolt
Use multi-backend Keras with TF 1 for tox build
a34bb24
@teabolt
Update TODO's and FIXME's
646c948
@teabolt
Try to use snap over apt for installing latest cmake
3d2955a
@teabolt
Use classic confinement for snap
c52245c
@teabolt
Install latest CMake version manually
1f78ea7
@teabolt
Install using existing CMake
cdd45b1
@teabolt
Try to install CMake via shell script
2f40e8c
@teabolt
Try to install CMake via pip
d790c58
@teabolt
Install sciki-learn version that supports python 2.7
1f17b2b
@teabolt
Install scikit-learn 0.21
ef876de
@teabolt
Update comments and docs
6a7eb3d
@teabolt
(Fix install) Install sciki-learn<0.23
e6c4981
@teabolt
Fix up and re-run keras notebooks
0009757
@teabolt
Keras docs: Explain cases where original GradCAM formula isn't followed
347ed35
@lopuhin
Merge branch 'master' into keras-gradcam-text
9e9935b
@lopuhin
revert version constraints, they are set in a separate file
cd31547
@lopuhin
add keras ignores to the newly added file
f0f06c0
@lopuhin
revert sklearn version constraint as we support newest now
e594976
@teabolt
Copy link
Collaborator

teabolt commented Jan 31, 2021

Hey @lopuhin

I checked out the docs that were built by tox and didn't find any issues. Added one small comment above but it might not even be an issue.

I also re-ran the keras notebooks using the py35-extra and py36-extra environments and didn't run into any issues. So I think the PR is ready

@teabolt
Copy link
Collaborator

teabolt commented Apr 7, 2021

Hey @lopuhin. Let me know if there's anything blocking this PR that I could fix. Maybe we are sticking with https://github.com/TeamHG-Memex/eli5 for now?

@lopuhin
Copy link
Contributor Author

lopuhin commented Apr 14, 2021

hi @teabolt I also think it's ready, just need to double-check everything and merge. We're sticking to this repo for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teabolt teabolt teabolt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lopuhin @teabolt