[App 780] Navigation Sidebar #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkniazevych
reviewed
Nov 17, 2024
pkniazevych
reviewed
Nov 17, 2024
pkniazevych
reviewed
Nov 17, 2024
pkniazevych
reviewed
Nov 17, 2024
pkniazevych
reviewed
Nov 17, 2024
pkniazevych
reviewed
Nov 17, 2024
pkniazevych
reviewed
Nov 17, 2024
There was a problem hiding this comment.
The overall functionality makes sense, just please confirm that the actual integration should go in some other ticket and we're good to go.
I also have confusion with some drifts we're doing from the existing codebase:
- Why do we use
export constfor some components, butexport defaultfor others? Why do we actively change it? What benefits it provides? As for cons, the code can quickly become inconsistent if we copy the modules from various plugins and also the differences might be confusing for the new team members. - Why do we add those re-export index.js files? That's more an existential question, bc I never really understood why people create those.
I think that's the point we should discuss those and make an agreement. If we start using those approaches, should we also consider updating IO and SM if it's beneficial?
DinetsV
reviewed
Nov 25, 2024
DinetsV
approved these changes
Nov 26, 2024
bainternet
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.