WindowManager: Only show notifications after their window was shown #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What do you mean with static object? Could you maybe link a resource or something because tbh I've never heard of static objects in GLib2.0 and a quick google search didn't bring anything either 😅 |
|
@leolost2605 I'm referring to this comment: #1587 (comment). TBH I have no idea what or why this happens, you should ask @tintou instead. |
|
Ah ok since we do it manually here I hope we should be ok but let's wait for his opinion :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2102
The private window_created signal was recently introduced. @lenemter could you provide some background why that was done since it seems to work like this as well?