Introduce a GesturePropertyTransition #2074
Open
+261
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
reviewed
Sep 26, 2024
|
Yeah that review request was a bit optimistic this still needs a few minor refinements:
|
|
Ok this should now finally be ready for review :) |
lenemter
reviewed
Dec 4, 2024
| * Emitted when all animations are finished that is when the property has reached the target value | ||
| * either via gesture or via easing or combined. | ||
| */ | ||
| public signal void done (); |
There was a problem hiding this comment.
As far as I can see this signal is used only inside the class, the users of the class seem to use done_callback. Should this signal be private instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a GesturePropertyTransition. This allows us to remove a lot of boilerplate code. For now it is a simple API that pretty much is used as a drop in replacement for connecting own handlers. In the future it can be easily expanded upon for more powerful usage. The nudge animations (both in multitasking view and while on the desktop) are a bit different now and IMHO a bit better (they can be changed back or to something different though).