Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on the SDK to decide if a caption is editable or not #3917

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 21, 2024

Need matrix-org/matrix-rust-sdk#4303 to work but not to compile.

Complement for #3902, let read the value from the SDK instead of computing it again in the application code.

Note: the Rust PR has been merged but we will need a SDK release to have the new behavior. Merging this PR before will temporarily disable edition of caption.

@bmarty bmarty added the PR-Misc For other changes label Nov 21, 2024
@bmarty bmarty requested a review from a team as a code owner November 21, 2024 14:04
@bmarty bmarty requested review from ganfra and removed request for a team November 21, 2024 14:04
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gByNBT

Copy link

sonarcloud bot commented Nov 21, 2024

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (e8af711) to head (560a04c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3917      +/-   ##
===========================================
- Coverage    82.95%   82.95%   -0.01%     
===========================================
  Files         1786     1786              
  Lines        45224    45222       -2     
  Branches      5338     5336       -2     
===========================================
- Hits         37517    37515       -2     
  Misses        5836     5836              
  Partials      1871     1871              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bmarty bmarty merged commit 3e1a8a3 into develop Nov 21, 2024
29 checks passed
@bmarty bmarty deleted the feature/bma/isEditableForCaption branch November 21, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants